Skip to content

[Not ready to merge] Migrating AttrName, ClassName, and PropName to web-dom. #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nsaunders
Copy link

Prerequisites

  • Before opening a pull request, please check the HTML standard (https://html.spec.whatwg.org/). If it doesn't appear in this spec, it may be present in the spec for one of the other purescript-web projects. Although MDN is a great resource, it is not a suitable reference for this project.

Description of the change

With this change, the AttrName, ClassName, and PropName types are re-exported from web-dom, completing the migration discussed in purescript-web/purescript-web-dom#56 and purescript-web/purescript-web-dom#58.

Warning
As this change depends on purescript-web/purescript-web-dom#58 which is not yet merged, the purescript-web-dom reference in bower.json points to my personal fork. This will of course need to be updated before this PR can be merged.


Checklist:

  • Added the change to the changelog's "Unreleased" section with a reference to this PR (e.g. "- Made a change (#0000)")
  • Linked any existing issues or proposals that this pull request should close
  • Updated or added relevant documentation N/A
  • Added a test for the contribution (if applicable) N/A

Sorry, something went wrong.

@flip111
Copy link

flip111 commented Nov 6, 2024

@nsaunders i guess this can be merged now since it is in web-dom?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants