Skip to content

NamedNodeMap & Attr #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 8 commits into from
Closed

Conversation

flip111
Copy link
Contributor

@flip111 flip111 commented Jan 27, 2022

https://dom.spec.whatwg.org/#interface-namednodemap
https://dom.spec.whatwg.org/#attr

#47

open checklist:

  • Actually run the code (only compiled so far)
  • Added the change to the changelog's "Unreleased" section with a reference to this PR (e.g. "- Made a change (#0000)")
  • Updated or added relevant documentation
  • Added a test for the contribution (if applicable)

@flip111
Copy link
Contributor Author

flip111 commented Jan 27, 2022

really doubt whether this Effect is needed everywhere ...
It's not so nice to work with ... shall i remove it ?

@garyb
Copy link
Member

garyb commented Oct 17, 2022

Thanks for working on this/updating it again and sorry about the lack of response so far, I don't have time to look at it properly just now but it's on my list of things to look at when I can 👍

@garyb garyb mentioned this pull request Sep 24, 2023
@flip111
Copy link
Contributor Author

flip111 commented Apr 16, 2024

Closing because follow up PR got merged.

@flip111 flip111 closed this Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants