Ember Data example #112
Open
Ember Data example #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added a new example page with a Fixtable populated via Ember Data, rather than a plain JavaScript array like all the existing examples. This was prompted by the issue @smargovsky reported where he was seeing undefined values passed to the row selection callback rather than the expected model objects.
Despite my attempts to follow his use case as closely as possible, everything is working fine on my new example page, without making any changes to the addon itself. I'm hoping @smargovsky can take a look at this branch and figure out where it differs from his implementation.