fix: parsing of (text encoded) addresses #88
+44
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romanofski
commented
Jan 6, 2025
romanofski
force-pushed
the
fix/text-address-parser
branch
from
108d00e to
6a60cae
Compare
romanofski
commented
Jan 8, 2025
src/Data/IMF/Text.hs
Outdated
| @@ -99,14 +100,20 @@ mailbox = Mailbox <$> optional displayName <*> angleAddr | |||
| readMailbox :: String -> Either String Mailbox | |||
| readMailbox = parseOnly (mailbox <* endOfInput) . T.pack | |||
|
|
|||
| quotedString :: Parser T.Text | |||
| quotedString = optionalFWS *> dquote *> phrase <* dquote | |||
There was a problem hiding this comment.
just realised that this misses the specials... like e.g."Mr. Doyle" <...>
romanofski
force-pushed
the
fix/text-address-parser
branch
from
6a60cae to
723bdbc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses the parsing issue of email addresses (specifically the display names) when using text parser. It mainly allows all non-ASCII letters, but sticks with the character classes of
atext.Fixes: #87
This adds an additional exported symbol
addressSpecas it is used to fix purebred-mua/purebred#515