Open
Conversation
Contributor
Author
|
Problem 3 is fixed, waiting for review. |
ayushuk
requested changes
Mar 3, 2023
Member
ayushuk
left a comment
ayushuk
left a comment
There was a problem hiding this comment.
Looks good, I forgot to test at this meeting but usually before we push a change relating to hardware we have a second person test it out. I'll do that at next meeting and approve.
ayushuk
requested changes
Mar 3, 2023
| from .terminal import terminal | ||
| ctx.invoke(upload, **upload_kwargs) | ||
| ctx.invoke(terminal, request_banner=False) | ||
| ctx.invoke(terminal, request_banner=False) No newline at end of file |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Fixed the first two issues with #245
Motivation:
To fix upload options
References (optional):
Closes #245
Test Plan:
pros upload --target v5 --slot 1 hello-world.binhave a binary called hello-world.bin in a directory with project.pros and it should upload successfullyrun the same command without a slot number
run the same command with
pros ut