-
Notifications
You must be signed in to change notification settings - Fork 582
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add function stdlib::sort_by #1384
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good, I am curious what other people think about it.
Regarding the pending signature of the CLA agreement, I'm still waiting for a reply from our legal department... No estimated timeline, of course. |
Since our legal department has not replied to me in 3 months, I sign the CLA at my own risk. Stalling this MR for an unknown amount of time just because I'm trying to follow the rules is ridiculous. |
Hi project maintainers, is anything else missing to merge this PR? I've signed the CLA months ago and at least one reviewer gave his approval (thanks for the support, @smortex). Kind regards, |
@XMol can you please rebase against the main branch? |
Will do... |
As I wrote, please do a rebase, not a merge. |
Sorry, I understood that, but I wasn't sure what GitHub would do when I press "sync fork". 🙂 |
yeah the button is shit :( |
Guess we now need to wait for the two pipelines to eventually fail in about 4 hours? The Acceptance tests on Ubuntu-ARM seem to be broken... |
Thanks for the prompt reaction, @bastelfreak. |
Summary
Add new Ruby function
stdlib::sort_by()
, emulating native Ruby'sEnumerable.sort_by()
for Puppet.Additional Context
stdlib::sort_by()
supports sorting Strings, Arrays and Hashesclone
/copy
, which would be identical to basicString::sort()
Related Issues
#1376
Checklist
puppet apply
version 7.24.0 on RHEL-7.9