Updating to latest PDK version #319
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is not ready for review and I will be further reviewing the files for changes |
…e to bug with heredoc
Updating to reflect versions supported
|
Closing PR this is just not picking up the tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To perform the prep properly and allow pdk testing to run with the recent Puppet gem issue affecting all bar the latest PDK and Puppet gem released the best thing was to upgrade to the latest version of PDK and as a result I tidied up PEADM
Due to this issue
voxpupuli/puppet-lint-strict_indent-check#20
I disabled strict lint check
Also due to
voxpupuli/puppet-lint-manifest_whitespace-check#23
I disabled manifest_whitespace_missing_newline_end_of_file