Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle additional edge cases in puppet.gemspec #9508

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions puppet.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -32,17 +32,24 @@ Gem::Specification.new do |spec|
spec.add_runtime_dependency('semantic_puppet', '~> 1.0')
spec.add_runtime_dependency('ostruct', '~> 0.6.0')

# If we're building a platform-specific gem, as indicated by spec.platform,
# include the corresponding runtime dependencies no matter which platform we're
# currently running on.
#
# If we're running in bundler, include runtime dependencies for the platform
# we're currently running on.
platform = spec.platform.to_s
if platform == 'universal-darwin'
if platform =~ /darwin/ || (defined?(Bundler) && RUBY_PLATFORM =~ /darwin/)
spec.add_runtime_dependency('CFPropertyList', ['>= 3.0.6', '< 4'])
end

if (platform == 'x64-mingw32' || platform == 'x86-mingw32') || Gem.win_platform?
if platform =~ /mingw/ || (defined?(Bundler) && Gem.win_platform?)
# ffi 1.16.0 - 1.16.2 are broken on Windows
spec.add_runtime_dependency('ffi', '>= 1.15.5', '< 1.17.0', '!= 1.16.0', '!= 1.16.1', '!= 1.16.2')
spec.add_runtime_dependency('minitar', '~> 0.9')
elsif !Gem.java_platform?
elsif platform =~ /java/ || (defined?(Bundler) && Gem.java_platform?)
# don't depend on syslog on jruby, it requires extensions
else
spec.add_runtime_dependency('syslog', '~> 0.1.2')
end
end