Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make cache and values fully thread-safe #9158

Merged
merged 1 commit into from
Nov 21, 2023
Merged

Make cache and values fully thread-safe #9158

merged 1 commit into from
Nov 21, 2023

Commits on Nov 16, 2023

  1. Make cache and values fully thread-safe 

    Not locking the default initialization can lead to race-conditions.

I don't think we can switch to Concurrent::Map, and it's compute_if_absent
method, because insertion order won't be maintained. So synchronize the long
way.

ref: ruby-concurrency/concurrent-ruby#970
Co-authored-by: Maciej Mensfeld <[email protected]>
resolves puppetlabs#8951
    @joshcooper
    joshcooper committed Nov 16, 2023
    Configuration menu
    Copy the full SHA
    f890191 View commit details
    Browse the repository at this point in the history