(MAINT) Refactor routerMap to not be a global#79
Open
justinstoller wants to merge 1 commit intomainfrom
Open
Conversation
For reasons of expediency a consumer requires creating two services within a process. Using a global variable prevents that from happening. This converts a global variable to a local one which a comment in the file alludes to being a valuable change regardless.
justinstoller
force-pushed
the
local-routerMap
branch
from
c922311 to
e7c7ee9
Compare
Member
Author
|
@eoinmcq Does this seem like a decent change to you, regardless of the rationale for it? |
Member
Author
|
There's no hurry on this at the moment as we went with a different approach with the downstream project. However, it seems like a valuable refactor so I will leave it open and we can circle back to it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For reasons of expediency a consumer requires creating two services within a process. Using a global variable prevents that from happening. This converts a global variable to a local one which a comment in the file alludes to being a valuable change regardless.