This repository has been archived by the owner on Jun 5, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 80
Added support for centos-7, and fixed quite a lot bugs. #87
Open
ashish1099
wants to merge
1
commit into
puppetlabs-toy-chest:master
Choose a base branch
from
ashish1099:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashish1099
commented
May 28, 2015
- Install passenger with specified version by user
- Removed variable which are not required.
- Added some package dependencies
- Used "unless" because compile fails with "exit status 0"
- Fixed apache module conf files
…ssenger with specified version by user, removed not required variable and lot more
The travis build is failing because of this error
|
command => 'passenger-install-apache2-module -a', | ||
logoutput => on_failure, | ||
creates => $passenger::mod_passenger_location, | ||
unless => "test -f $passenger::mod_passenger_location", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is redundant with the creates
check in L7; if actually requiring a file (and not a symlink or directory) here is necessary, please remove the creates
The actual travis errors can be seen right above that line:
and should be trivial to fix. I do not quite understand why all that code needs to move from |
@DavidS make sense, i will update it |
@@ -1,13 +1,12 @@ | |||
class passenger::install { | |||
|
|||
package { 'passenger': | |||
ensure => $passenger::package_ensure, | |||
name => $passenger::package_name, | |||
ensure => $passenger::passenger_version, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't this line the only actual fix for MODULES-2072?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.