Skip to content
This repository has been archived by the owner on Jun 5, 2020. It is now read-only.

Added support for centos-7, and fixed quite a lot bugs. #87

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ashish1099
Copy link

  1. Install passenger with specified version by user
  2. Removed variable which are not required.
  3. Added some package dependencies
  4. Used "unless" because compile fails with "exit status 0"
  5. Fixed apache module conf files

…ssenger with specified version by user, removed not required variable and lot more
@ashish1099
Copy link
Author

The travis build is failing because of this error

The command "bundle exec rake validate && bundle exec rake lint && bundle exec rake spec SPEC_OPTS='--color --format documentation'" exited with 1

command => 'passenger-install-apache2-module -a',
logoutput => on_failure,
creates => $passenger::mod_passenger_location,
unless => "test -f $passenger::mod_passenger_location",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is redundant with the creates check in L7; if actually requiring a file (and not a symlink or directory) here is necessary, please remove the creates

@DavidS
Copy link
Contributor

DavidS commented Jul 3, 2015

The actual travis errors can be seen right above that line:

manifests/compile.pp - WARNING: variable not enclosed in {} on line 8
manifests/options.pp - WARNING: case statement without a default case on line 33
manifests/options.pp - WARNING: double quoted string containing no variables on line 35
manifests/options.pp - WARNING: double quoted string containing no variables on line 40
manifests/options.pp - WARNING: variable not enclosed in {} on line 18
manifests/options.pp - WARNING: variable not enclosed in {} on line 19
manifests/options.pp - WARNING: variable not enclosed in {} on line 42
manifests/options.pp - WARNING: variable not enclosed in {} on line 53
manifests/options.pp - WARNING: variable not enclosed in {} on line 54

and should be trivial to fix.

I do not quite understand why all that code needs to move from params to options.

@ashish1099
Copy link
Author

@DavidS make sense, i will update it

@@ -1,13 +1,12 @@
class passenger::install {

package { 'passenger':
ensure => $passenger::package_ensure,
name => $passenger::package_name,
ensure => $passenger::passenger_version,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this line the only actual fix for MODULES-2072?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants