Added bot user agent to non-scrolled page #30
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While trying this script with both LazySizes and LazyLoad libraries, I found out that the tests would always fail. It seems that the bot user agent wasn't specified, either unintentionally or not, but it caused much confusion.
Lazyload uses the IntersectionObserver API, so the test failing cause lots of confusion about why was this happening.
Here's the issue where this was being discussed: verlok/vanilla-lazyload#277
This is the main repo for both libraries:
To clarify, I've run the script on a project i'm working on, which had two different implementations of lazyloading on different branches, one with lazysizes, another one with lazyload, and both failed, even though they are actually implemented in a way that should be compliant according to the docs (https://developers.google.com/search/docs/guides/lazy-loading).
Hope this helps.
Also, if the exclusion of the UA is intentional, It would be good to have an explanation. Someone actually asked this some time ago, but received no answer (#27).