Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed datetime.now() to datetime.now(UTC) #119

Merged
merged 5 commits into from
Mar 28, 2025
Merged

changed datetime.now() to datetime.now(UTC) #119

merged 5 commits into from
Mar 28, 2025

Conversation

s0larish
Copy link
Contributor

All the times are in UTC format and not in the local time based on the processing machine.

@s0larish s0larish requested a review from jmbhughes March 26, 2025 20:20
Copy link

codecov bot commented Mar 26, 2025

Codecov Report

Attention: Patch coverage is 30.95238% with 29 lines in your changes missing coverage. Please review.

Project coverage is 41.95%. Comparing base (a816ad6) to head (d39bba0).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
punchpipe/flows/levelq.py 0.00% 7 Missing ⚠️
punchpipe/flows/fcorona.py 0.00% 3 Missing ⚠️
punchpipe/flows/level0.py 0.00% 3 Missing ⚠️
punchpipe/flows/level3.py 0.00% 3 Missing ⚠️
punchpipe/flows/starfield.py 0.00% 3 Missing ⚠️
punchpipe/monitor/app.py 0.00% 3 Missing ⚠️
punchpipe/cli.py 0.00% 2 Missing ⚠️
punchpipe/control/health.py 0.00% 2 Missing ⚠️
punchpipe/flows/velocity.py 0.00% 2 Missing ⚠️
punchpipe/control/processor.py 75.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #119   +/-   ##
=======================================
  Coverage   41.95%   41.95%           
=======================================
  Files          28       28           
  Lines        1690     1690           
=======================================
  Hits          709      709           
  Misses        981      981           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jmbhughes
Copy link
Member

pre-commit.ci autofix

@jmbhughes jmbhughes changed the title changed datetime.now() to datetime.now(timezone.utc) changed datetime.now() to datetime.now(UTC) Mar 28, 2025
Copy link
Member

@jmbhughes jmbhughes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@jmbhughes jmbhughes merged commit 9030373 into main Mar 28, 2025
5 checks passed
@jmbhughes jmbhughes deleted the utctimezones branch March 28, 2025 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants