Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes ruff noqa statement #383

Merged
merged 5 commits into from
Mar 10, 2025
Merged

Fixes ruff noqa statement #383

merged 5 commits into from
Mar 10, 2025

Conversation

jmbhughes
Copy link
Member

There was an extra statement that cased a Ruff failure. This fixes that.

@jmbhughes jmbhughes requested a review from lowderchris March 9, 2025 21:13
@jmbhughes
Copy link
Member Author

pre-commit.ci autofix

@jmbhughes jmbhughes self-assigned this Mar 9, 2025
@jmbhughes jmbhughes requested review from a team and removed request for lowderchris March 9, 2025 21:15
@jmbhughes jmbhughes changed the title Remove unneeded ruff noqa statement Fixes ruff noqa statement Mar 9, 2025
@jmbhughes
Copy link
Member Author

jmbhughes commented Mar 9, 2025

@punch-mission/swri-soc Something funny is happening where it passes (pre-commit is happy) and fails (the CI is unhappy) kind of at the same time. Maybe it's being checked with different ruff versions.

@jmbhughes
Copy link
Member Author

pre-commit.ci autofix

Copy link

codecov bot commented Mar 10, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 81.90%. Comparing base (a64d854) to head (b113594).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
punchbowl/data/sample.py 0.00% 1 Missing ⚠️

❌ Your patch status has failed because the patch coverage (0.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.
❌ Your project status has failed because the head coverage (81.90%) is below the target coverage (92.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #383      +/-   ##
==========================================
+ Coverage   81.53%   81.90%   +0.37%     
==========================================
  Files          61       63       +2     
  Lines        4050     4161     +111     
==========================================
+ Hits         3302     3408     +106     
- Misses        748      753       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jmbhughes jmbhughes merged commit 641d3b2 into main Mar 10, 2025
6 of 8 checks passed
@jmbhughes jmbhughes deleted the Removes-unneeded-ruff-noqa branch March 10, 2025 21:38
jmbhughes added a commit that referenced this pull request Mar 11, 2025
* Make cmap a variable

* Update visualize.py

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* updates for new usage of punch colormap

* Fixes ruff noqa statement (#383)

* make ruff happy

* Update sample.py

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Update .pre-commit-config.yaml

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* Make cmap a variable

* Update visualize.py

* updates for new usage of punch colormap

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Chris Lowder <[email protected]>
jmbhughes added a commit that referenced this pull request Mar 14, 2025
* create the build_psf_transform utility

* add type hints

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Fixes ruff noqa statement (#383)

* make ruff happy

* Update sample.py

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Update .pre-commit-config.yaml

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* create the build_psf_transform utility

* add type hints

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants