Fix invalid "internal" import in SDK gen #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blampe
commented
Mar 7, 2024
Comment on lines
+37
to
+46
| Metadata: schema.Metadata{ | ||
| DisplayName: "xyz", | ||
| Description: "Provider boilerplate", | ||
| LanguageMap: map[string]any{ | ||
| "go": gen.GoPackageInfo{ | ||
| Generics: gen.GenericsSettingGenericsOnly, | ||
| ImportBasePath: "github.com/pulumi/pulumi-xyz/sdk/go/xyz", | ||
| }, | ||
| }, | ||
| }, |
Comment on lines
+10
to
+12
| "github.com/pulumi/pulumi-xyz/sdk/go/xyz/internal" | ||
| "github.com/pulumi/pulumi/sdk/v3/go/pulumi" | ||
| "internal" | ||
| "github.com/pulumi/pulumi/sdk/v3/go/pulumix" |
There was a problem hiding this comment.
I'm not sure how examples were able to pass with this import...
blampe
changed the title
iwahbe
approved these changes
Mar 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Metadatato the provider, includingGoPackageInfowhich fixes the invalid "internal" import we were generating with the SDK..gitattributesto ignore generated SDK code by default.Workaround for pulumi/pulumi#13756.