chore(release): v0.45.1 — #757 soundness fix (overlapping-segment reloc miscompile)#780
Merged
Conversation
… segments bind reloc to the wrong segment) gale delivered the exact fused loom.wasm; root cause = 3 active data segments all at linmem 0x100000, WASM later-overwrites-earlier, but the #354 reloc retargeting used .position() (first match) → string source bound to stale seg_0 not seg_2. Fix: .position()→.rposition() (last-declared owner). Byte-identical for non-overlapping; frozen 10/10; loom.wasm pinned as permanent CI fixture. #757 closed. Follow-up: VCR-VER-003 (#777). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01YJK5LZZEkV5smCY1jKn18L
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Soundness patch. Closes #757 — root-caused + fixed on gale's exact
loom.wasm(PR #779).Fixed
0x100000; the#354reloc retargeting used.position()(first match), binding the string source to staleseg_0instead of the runtime-owningseg_2. Fix.position()→.rposition(). Verified red→green on gale's exact bytes; byte-identical for non-overlapping segments (frozen 10/10,#739/#746/#758/#406differentials green).loom.wasmpinned as a permanent CI regression fixture.Note
#739/#746/#757/#758class unrepresentable by construction.Pin sweep 0.45.0→0.45.1 (workspace + path-deps + MODULE.bazel + npm). Claim gate 19/19. fmt clean.
🤖 Generated with Claude Code