Skip to content

Hide empty file-info element in status bar#1415

Open
asiloisad wants to merge 1 commit intopulsar-edit:masterfrom
asiloisad:empty-status-bar-file-fix
Open

Hide empty file-info element in status bar#1415
asiloisad wants to merge 1 commit intopulsar-edit:masterfrom
asiloisad:empty-status-bar-file-fix

Conversation

@asiloisad
Copy link
Copy Markdown
Contributor

Hide the status-bar-file element when no file path or title is available, preventing an empty element from taking up space in the status bar.

When there is no active pane item with a path or title (e.g. all tabs are closed), the <a class="current-path"> child was hidden via the existing .current-path:empty CSS rule, but the parent <status-bar-file> element remained visible and occupied space in the status bar.

This adds a style.display toggle in updatePathText() to hide the entire element when the content is empty and restore it when content is available.

Copy link
Copy Markdown
Member

@confused-Techie confused-Techie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feels like a no brainer, changes are simple and seem to ensure it's always updated as needed.

Thanks a ton for contributing! I'll leave it up for a short while to let anyone else chime in, but otherwise this LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants