Fix tree-view crash when dock pane is split #1409
Open
+1
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Root Cause
During startup, the tree-view item may be deserialized into a specific pane within a split dock (e.g. pane B). When
activate()then callsworkspace.open(treeView, ...)withoutsearchAllPanes: true, the workspace resolves the target pane viapaneContainerForURI()→container.getActivePane(), which returns the active pane in the dock (pane A), not necessarily the one holding the deserialized tree-view (pane B).Since
pane.addItem()only guards against duplicates within its own items array, the item passes the local check on pane A but fails the globalItemRegistrycheck — because it was already registered when deserialized into pane B.Fix
Add
searchAllPanes: trueto theworkspace.opencall inactivate(). This makes the workspace usepaneForItem(item), which searches all panes across all containers, correctly locating the already-deserialized item regardless of which pane in a split dock holds it.