docs: improve Publishing section #22
Conversation
There was a problem hiding this comment.
Yeah, I'm happy to take the reworking of the “things to double-check before publishing” list, but most of the rest is a simple rephrasing rather than adding new information or removing inaccurate information. I may apply the one change on its own and respectfully decline to change the rest of it.
I'll be ok with any decision you'll take. |
| <!-- TODO: Rewrite this Section once Authentication Information is Public --> | ||
| `pulsar -p login` will let you create and set an API token in your keychain to permit interacting with GitHub API | ||
|
|
||
| If this is the first package you are publishing, the `pulsar -p publish` command may prompt you for your GitHub username and password. If you have two-factor authentication enabled, use a [personal access token](https://help.github.com/articles/creating-a-personal-access-token-for-the-command-line/) in lieu of a password. This is required to publish and you only need to enter this information the first time you publish. The credentials are stored securely in your [keychain](<https://en.wikipedia.org/wiki/Keychain_(software)>) once you login. |
There was a problem hiding this comment.
I understand this change better after your comment on the other PR. I agree that this information is wrong, but I'd like to make sure we replace it with correct information. Did you hit this code path when you tried to publish?
There was a problem hiding this comment.
I added the keychain info at line 34, and discarded all the rest. let me know if that works out
ndr-brt
force-pushed
the
improve-publishing-section
branch
from
3c4924e to
abd2382
Compare
What
Adaptation of pulsar-edit/pulsar-edit.github.io#297
to this repository
Notes
Improve and update "publishing" section, specifically it adds some docs for the
loginpart