[PULP-817] Adjustments to make imp/exp work with django-imp-exp 4.x. #6973
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
May require plugin-changes to adapt to django-import-export:4.x - DO NOT MERGE until 3.100. |
ggainey
force-pushed
the
django_impexp_4
branch
2 times, most recently
from
922ff33 to
d2916d8
Compare
mdellweg
reviewed
Sep 24, 2025
Comment on lines
+65
to
+66
| if row[checksum] == "" or checksum not in settings.ALLOWED_CONTENT_CHECKSUMS: | ||
| del row[checksum] |
There was a problem hiding this comment.
Random unrelated question: Do we recalculate missing checksums on import? Or do both systems need the same setting there?
There was a problem hiding this comment.
Fine question, and the answers are "no we don't" and "...huh." I expect that, "in the wild", systems being exported-to have the same settings as the system being exported-from, so it just never came up. But it's a de-facto standard, not a de-jure one :)
ggainey
force-pushed
the
django_impexp_4
branch
from
d2916d8 to
31b150e
Compare
ggainey
force-pushed
the
django_impexp_4
branch
from
31b150e to
605dd8a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #5324.