Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OPEN: Snitch Cluster Tiling Support #22

Merged
merged 11 commits into from
Jan 9, 2025

Conversation

tahaelbayad
Copy link
Contributor

@tahaelbayad tahaelbayad commented Dec 13, 2024

This PR mirrors a PR from the GitLab repository, extending the support for snitch_cluster platform by adding support for single-buffered tiling and more operators, such as:

  • RequantizedGEMM
  • RequantizedAdd
  • Add
  • iSoftmax
  • iNoNorm

Added

  • Support for single-buffered tiling from L2.
  • Parsers, Templates, TypeCheckers, Layers, and TCF for the newly supported operators.
  • A code transformation pass to filter DMA cores or compute cores for an ExecutionBlock.
  • A code transformation pass to profile an ExecutionBlock.
  • Test for single kernels, both with and without tiling.
  • Adds the --debug flag to cargo install when installing Banshee to get the possibility of enabling the debug prints.
  • New tests for the snitch_cluster platform.
  • Add macros to main.c to disable printing and testing (convenient when running RTL simulations).

Changed

  • Add the possibility of changing the simulator when using the snitch-tiled test runner.

Fixed

  • Add the possibility of changing the simulator when using the snitch-tiled test runner.

PR Merge Checklist

  1. The PR is rebased on the latest devel commit and pointing to devel.
  2. Your PR reviewed and approved.
  3. All checks are passing.
  4. The CHANGELOG.md file has been updated.

@Victor-Jung Victor-Jung changed the title DRAFT: Snitch Cluster support DRAFT: Snitch Cluster Tiling Support Dec 13, 2024
@tahaelbayad tahaelbayad marked this pull request as ready for review December 13, 2024 10:38
@tahaelbayad tahaelbayad changed the title DRAFT: Snitch Cluster Tiling Support OPEN: Snitch Cluster Tiling Support Dec 13, 2024
Copy link
Member

@Victor-Jung Victor-Jung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First round of comments, I haven't had time to give a pass on everything yet.

.github/workflows/BuildDocker.yml Outdated Show resolved Hide resolved
.github/workflows/CI.yml Outdated Show resolved Hide resolved
.github/workflows/CI.yml Outdated Show resolved Hide resolved
.github/workflows/TestRunnerTiledSnitch.yml Outdated Show resolved Hide resolved
.gitmodules Outdated Show resolved Hide resolved
Copy link
Member

@Victor-Jung Victor-Jung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All my comments from my previous pass were addressed. I have two more comments that require some changes, mostly refactoring, since you know the codebase by now this should be done in a day :)

Deeploy/Targets/Snitch/Templates/RQAddTemplate.py Outdated Show resolved Hide resolved
Deeploy/Targets/Snitch/TypeCheckers.py Outdated Show resolved Hide resolved
@Victor-Jung
Copy link
Member

LGTM, ready to merge as soon as the pipeline passes.

@Victor-Jung Victor-Jung merged commit c3f11d6 into pulp-platform:devel Jan 9, 2025
106 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants