Feature: Settings to enable telemetry for extension #55
Conversation
hassan-pullflow
force-pushed
the
feature/disable-telemetry
branch
from
af561f3 to
026b3b1
Compare
🚂 Release 1.2.2
…into feature/disable-telemetry
srzainab
changed the base branch from
feature/quickpick-telemetry
to
epic/telemetry
…e-pullflow into srzainab/issue56
src/utils/trace.ts
Outdated
| type FakeBasicTracerProvider = {} | ||
| type FakeAttribute = {} | ||
|
|
||
| // Null Object Design pattern |
There was a problem hiding this comment.
do we need this comment here?
src/utils/trace.ts
Outdated
|
|
||
| dispose(): void {} | ||
| start({ name, attributes }: { name: string; attributes?: TraceAttributes }) { | ||
| console.log({ name, attributes }) |
There was a problem hiding this comment.
why are we doing console log here?
There was a problem hiding this comment.
because i need to use the attributes and name somehow otherwise it gives unused values errors.
There was a problem hiding this comment.
we can do it like one of these ways:
start({ _name, _attributes }: { name: string; attributes?: TraceAttributes }) { ... }
start({ }: { name: string; attributes?: TraceAttributes }) { ... }
what do you think @srzainab?
…e-pullflow into feature/disable-telemetry
Co-authored-by: Amna Anwar <[email protected]>
Add settings for disabling flow
src/utils/trace.ts
Outdated
|
|
||
| dispose(): void {} | ||
| start({ name, attributes }: { name: string; attributes?: TraceAttributes }) { | ||
| console.log({ name, attributes }) |
There was a problem hiding this comment.
we can do it like one of these ways:
start({ _name, _attributes }: { name: string; attributes?: TraceAttributes }) { ... }
start({ }: { name: string; attributes?: TraceAttributes }) { ... }
what do you think @srzainab?
…e-pullflow into feature/disable-telemetry
|
@amna-pullflow updated the PR. will merge once the tests pass. |
Summary of Changes
package.jsoninitialize.tsisTelemetryEnabledflag inCacheObjectSnap-Shots
PR-Specific-Tests