Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Add tracing for quickpicks #54

Merged
merged 5 commits into from
Jan 15, 2024
Merged

Feature: Add tracing for quickpicks #54

merged 5 commits into from
Jan 15, 2024

Conversation

hassan-pullflow
Copy link
Contributor

Summary of Changes

  • added tracing for quickpicks in quickPick.ts

Snap-Shots

Screenshot 2024-01-04 at 3 08 50 PM Screenshot 2024-01-04 at 3 02 59 PM

srzainab
srzainab approved these changes Jan 10, 2024
View reviewed changes
Copy link
Collaborator

@srzainab srzainab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a better way to organize this code so we don't have to pass context explicitly in each QuickPick call?

@srzainab srzainab changed the base branch from feature/tracer-initialization to epic/telemetry January 15, 2024 12:25
@srzainab srzainab merged commit 952476c into epic/telemetry Jan 15, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srzainab srzainab srzainab approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hassan-pullflow @srzainab