Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: VSCode doesn't remove flow icon; removed from Slack #47

Merged
merged 3 commits into from
Jan 3, 2024
Merged

Fix: VSCode doesn't remove flow icon; removed from Slack #47

merged 3 commits into from
Jan 3, 2024

Conversation

hassan-pullflow
Copy link
Contributor

Summary of Changes

  • reseting UserPresence.resetState on activation.
  • added INACTIVE state for presence.

PR-Specific-Tests

  • Slack status and VS Code status bar are always in sync for flow icon.

@hassan-pullflow hassan-pullflow linked an issue Jan 1, 2024 that may be closed by this pull request
Fix: VSCode doesn't remove flow icon; removed from Slack #49
Closed
@srzainab srzainab added this to the 1.2.2 milestone Jan 2, 2024
@hassan-pullflow hassan-pullflow merged commit 4b1e154 into release/1.2.2 Jan 3, 2024
1 check passed
@iffat-pullflow iffat-pullflow mentioned this pull request Jan 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srzainab srzainab srzainab approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.2.2
Development

Successfully merging this pull request may close these issues.

Fix: VSCode doesn't remove flow icon; removed from Slack
2 participants
@hassan-pullflow @srzainab