Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Status bar should be updated after action taken #43

Merged
merged 5 commits into from
Dec 26, 2023
Merged

Feature: Status bar should be updated after action taken #43

merged 5 commits into from
Dec 26, 2023

Conversation

hassan-pullflow
Copy link
Contributor

Summary of Changes

  • added function updateWithDelay in PullRequestState.
  • updating PullRequestState after every action.
  • ref: renamed isLogin to showLoading in PullRequestState.update
  • added unit testing for pullRequestQuickActions.ts

Review-Tips

  • Start with pullRequestQuickActions.ts

PR-Specific-Tests

  • User performs any actions on pull request > Status bar should be updated after 3 seconds.

@hassan-pullflow hassan-pullflow linked an issue Dec 19, 2023 that may be closed by this pull request
Status bar should be updated after action taken #34
Closed
@hassan-pullflow hassan-pullflow changed the base branch from main to release/1.2.2 December 19, 2023 10:09
srzainab
srzainab approved these changes Dec 22, 2023
View reviewed changes
Copy link
Collaborator

@srzainab srzainab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

src/pullRequestQuickActions/pullRequestQuickActions.test.ts Outdated Show resolved Hide resolved
@hassan-pullflow hassan-pullflow merged commit dba9f22 into release/1.2.2 Dec 26, 2023
1 check passed
@iffat-pullflow iffat-pullflow mentioned this pull request Jan 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amna-pullflow amna-pullflow amna-pullflow approved these changes

@srzainab srzainab srzainab approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Status bar should be updated after action taken
3 participants
@hassan-pullflow @srzainab @amna-pullflow