fixed typing on quickpick

pullflow · Nov 10, 2023 · e92c143 · e92c143
1 parent 3f0d867
commit e92c143
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 6 deletions.
diff --git a/src/utils/types.ts b/src/utils/types.ts
@@ -75,6 +75,10 @@ export interface ReviewerSelectionItem extends QuickPickItem {
   hasUser: boolean
   xid: string
 }
+export interface SpaceUserSelectionItem extends QuickPickItem {
+  label: string
+  description: string
+}
 export enum CodeReviewType {
   Pending,
   Authored,
@@ -89,6 +93,7 @@ export enum ActivePullRequestActions {
   ApplyLabel = 'Add label',
   AddAssignee = 'Add assignee',
   RequestReview = 'Add reviewer',
+  SetReminder = 'Set a reminder',
 }
 export type SpaceUser = {
   id: string
@@ -112,6 +117,7 @@ export type ApiVariables =
   | AddAssigneeVariables
   | RequestReviewVariables
   | CodeReviewApproveVariables
+  | CodeReviewRemindersVariables
 export type ThreadMessageVariables = {
   body: string
   parentMessageXid: string
@@ -149,6 +155,10 @@ export type CodeReviewApproveVariables = {
   codeReviewId: string
   body?: string
 }
+export type CodeReviewRemindersVariables = {
+  codeReviewId: string
+  duration: number
+}
 export type RepoInfo = {
   repoName?: string
   branch?: string

diff --git a/src/views/quickpicks/quickPick.ts b/src/views/quickpicks/quickPick.ts
@@ -1,18 +1,18 @@
 import { QuickPickItem, window } from 'vscode'
 
 export const QuickPick = {
-  create: ({
+  create: <Type extends QuickPickItem>({
     items,
     title,
     placeholder,
     onDidChangeSelection,
   }: {
-    items: QuickPickItem[]
+    items: Type[]
     title: string
     placeholder: string
-    onDidChangeSelection: (selection: readonly QuickPickItem[]) => void
+    onDidChangeSelection: (selection: readonly Type[]) => void
   }) => {
-    const quickPick = window.createQuickPick()
+    const quickPick = window.createQuickPick<Type>()
     quickPick.items = items
     quickPick.title = title
     quickPick.placeholder = placeholder

diff --git a/src/views/quickpicks/spaceUserPicker.ts b/src/views/quickpicks/spaceUserPicker.ts
@@ -1,6 +1,6 @@
 import { ExtensionContext, window } from 'vscode'
 import { Store } from '../../utils/store'
-import { SpaceUser } from '../../utils'
+import { SpaceUser, SpaceUserSelectionItem } from '../../utils'
 import { QuickPick } from './quickPick'
 
 export const spaceUserPicker = ({
@@ -12,7 +12,9 @@ export const spaceUserPicker = ({
   context: ExtensionContext
   placeholder: string
   title: string
-  onDidChangeSelection: (item: any) => Promise<boolean>
+  onDidChangeSelection: (
+    item: readonly SpaceUserSelectionItem[]
+  ) => Promise<boolean>
 }) => {
   const spaceUsers = Store.get(context)?.spaceUsers
   if (!spaceUsers) {