I98 gitlab install #5425
Merged
I98 gitlab install #5425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kayiwa
force-pushed
the
i98_gitlab_install
branch
4 times, most recently
from
b3dfd2d
to
ed6fe12
Compare
acozine
reviewed
Oct 7, 2024
There was a problem hiding this comment.
This is a lot of work and a great step forward.
I'd like to see consistency in naming - right now some elements are named git_x and others are pulgit_x and others are gitlab_x. Why not make it easy on ourselves and call everything (inventory, VM names, DNS, role, etc., etc.) gitlab? It's clear and consistent and describes precisely what the system does.
we add FQRN to the examples which we use when we create new roles
add the tasks that will install gitlab
the template file will need to be parametrized this is the initial configuration
point to this role in the converge file also
add configuration for a staging environment add loadbalancer configuration
the gitlab configure command takes ages to run in a container
kayiwa
force-pushed
the
i98_gitlab_install
branch
from
7a690b9
to
87e52d3
Compare
move name to gitlab for production
acozine
reviewed
Oct 8, 2024
acozine
reviewed
Oct 8, 2024
Co-authored-by: Alicia Cozine <[email protected]>
Co-authored-by: Alicia Cozine <[email protected]> Co-authored-by: Vickie Karasic <[email protected]>
Co-authored-by: Alicia Cozine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR installs local ldap enabled gitlab instance for private repos.
Related to pulibrary/ops-catchall#84