Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[prancible] upgrade the version of ansible #4580

Merged
merged 23 commits into from
Jan 23, 2024
Merged

Conversation

kayiwa
Copy link
Member

@kayiwa kayiwa commented Jan 11, 2024

this updates our version of ansible to 9.1.0

closes #4567

Copy link
Contributor

@VickieKarasic VickieKarasic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me - thanks @kayiwa

Copy link
Contributor

@acozine acozine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm eager to get Ansible upgraded, but I would like to see at least some Molecule tests run and succeed before merging this. It looks like our CI suite just skipped everything - they all seem to say "successful" but in under 60 seconds each, which doesn't sound like any tests actually ran. I'm going to review this as "Request changes" but the PR itself looks fine - the review is only intended to hold up merging until we can at least run the tests locally.

point all remain containers to use the quay.io image that uses jammy
Copy link
Contributor

@acozine acozine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is doing a lot of great stuff! The Tomcat changes are a little confusing, and there's still a CI failure, but we're getting there.

roles/tomcat9/defaults/main.yml Outdated Show resolved Hide resolved
roles/tomcat9/handlers/main.yml Outdated Show resolved Hide resolved
roles/tomcat9/meta/main.yml Outdated Show resolved Hide resolved
roles/tomcat9/meta/main.yml Show resolved Hide resolved
roles/tomcat9/molecule/default/converge.yml Outdated Show resolved Hide resolved
roles/tomcat9/vars/main.yml Outdated Show resolved Hide resolved
@kayiwa kayiwa force-pushed the i4567_upgrade_ansible branch 2 times, most recently from d8a327a to 67d1613 Compare January 19, 2024 18:48
Copy link
Contributor

@acozine acozine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI success, huzzah!

@acozine acozine merged commit 78c6667 into main Jan 23, 2024
65 checks passed
@acozine acozine deleted the i4567_upgrade_ansible branch January 23, 2024 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Maintenance playbook should run apt clean
3 participants