-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[prancible] upgrade the version of ansible #4580
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me - thanks @kayiwa
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm eager to get Ansible upgraded, but I would like to see at least some Molecule tests run and succeed before merging this. It looks like our CI suite just skipped everything - they all seem to say "successful" but in under 60 seconds each, which doesn't sound like any tests actually ran. I'm going to review this as "Request changes" but the PR itself looks fine - the review is only intended to hold up merging until we can at least run the tests locally.
point all remain containers to use the quay.io image that uses jammy
b0907ac
to
7b112f1
Compare
7b112f1
to
3d08909
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR is doing a lot of great stuff! The Tomcat changes are a little confusing, and there's still a CI failure, but we're getting there.
3797189
to
f216f98
Compare
d8a327a
to
67d1613
Compare
67d1613
to
5b60196
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CI success, huzzah!
this updates our version of ansible to 9.1.0
closes #4567