Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

i107: Don't error if the user enters a partial date range #115

Merged
merged 1 commit into from
Mar 1, 2024
Merged

i107: Don't error if the user enters a partial date range #115

merged 1 commit into from
Mar 1, 2024

Conversation

sandbergja
Copy link
Member

Thanks to @maxkadel for identifying the circumstances that cause this error!

closes #107

@sandbergja sandbergja assigned maxkadel and unassigned maxkadel Feb 29, 2024
@sandbergja sandbergja requested a review from maxkadel March 1, 2024 00:03
christinach
christinach approved these changes Mar 1, 2024
View reviewed changes
Copy link
Member

@christinach christinach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sandbergja and @maxkadel

maxkadel
maxkadel approved these changes Mar 1, 2024
View reviewed changes
Copy link
Contributor

@maxkadel maxkadel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sandbergja! 🍄

@maxkadel maxkadel merged commit 27e1f42 into main Mar 1, 2024
6 checks passed
@maxkadel maxkadel deleted the i107-toLocaleDateString branch March 1, 2024 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christinach christinach christinach approved these changes

@maxkadel maxkadel maxkadel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DatePicker range bugs
3 participants
@sandbergja @christinach @maxkadel