Add test coverage measuring #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds excoveralls (which is the state of the art coverage tool) and a `mix spec` command which will run the whole suite with an HTML export of coverage. Closes #37
hackartisan
requested changes
Jul 17, 2024
There was a problem hiding this comment.
Looks good! I tried it, it doesn't seem to print out the coverage when you run mix test -- is it determined separately / statically? mix coveralls seems to work, but I'm not sure where to see the html view you referenced. Can you add to the readme instructions for how to run / view coverage?
hackartisan
reviewed
Jul 17, 2024
| @@ -9,7 +9,16 @@ defmodule DpulCollections.MixProject do | |||
| elixirc_paths: elixirc_paths(Mix.env()), | |||
| start_permanent: Mix.env() == :prod, | |||
| aliases: aliases(), | |||
| deps: deps() | |||
| deps: deps(), | |||
| test_coverage: [tool: ExCoveralls], | |||
There was a problem hiding this comment.
oh i guess this makes mix test --cover use excoveralls
|
@hackartisan Mix spec or mix coveralls.html should generate the html page. |
|
@tpendragon can you add that to the readme |
Yup! |
hackartisan
approved these changes
Jul 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds excoveralls (which is the state of the art coverage tool) and a
mix speccommand which will run the whole suite with an HTML export of coverage and fail if the coverage is less than 100%.I decided on excoveralls based on the HTML view of
mix test --covernot having a table of contents to see all coverage in one place. Read on https://elixirforum.com/t/code-coverage-tools-for-elixir/18102 thatexcoverallswas the best option, and it seems well maintained.Closes #37