Add deploy script. #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes #21 Not sure this is the best script, and the output includes the SSH banner and stuff, but it's pretty simple!
hackartisan
requested changes
Jun 18, 2024
There was a problem hiding this comment.
We're looking together at this and one thing that @tpendragon noted is that the deploy never fails. Trey's suggestion is that maybe we can get the exit status from the nomad job command, which runs synchronously to the whole job.
Co-authored-by: Anna Headley <[email protected]> Co-authored-by: Shaun Ellis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs #21
Not sure this is the best script, and the output includes the SSH banner and stuff, but it's pretty simple!
This does Slack notifications by updating Github, which will notify slack since we've registered deployment notifications in #figgy!