Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace ISO 639 gem with one that includes ISO 639-3 #2089

Merged
merged 2 commits into from
Mar 9, 2023
Merged

Conversation

sandbergja
Copy link
Member

In preparation for #2069

maxkadel
maxkadel previously approved these changes Mar 8, 2023
Copy link
Contributor

@maxkadel maxkadel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve, although I would appreciate a newline on the .tsv file, unless there's something I don't know.

🍄 🎵

http://id.loc.gov/vocabulary/iso639-5/zle zle East Slavic languages slaves orientales, langues
http://id.loc.gov/vocabulary/iso639-5/zls zls South Slavic languages slaves méridionales, langues
http://id.loc.gov/vocabulary/iso639-5/zlw zlw West Slavic languages slaves occidentales, langues
http://id.loc.gov/vocabulary/iso639-5/znd znd Zande languages zandé, langues
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
http://id.loc.gov/vocabulary/iso639-5/znd znd Zande languages zandé, langues
http://id.loc.gov/vocabulary/iso639-5/znd znd Zande languages zandé, langues

namespace :iso639_5 do
desc 'refresh the list of collective language codes in this repo from LOC'
task :refresh_list do
`wget http://id.loc.gov/vocabulary/iso639-5.tsv -O config/iso639-5.tsv`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

Copy link
Contributor

@maxkadel maxkadel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 Awesome! 🎉

🍄

@sandbergja sandbergja merged commit b681c48 into main Mar 9, 2023
@sandbergja sandbergja deleted the i2069-iso639-3 branch March 9, 2023 16:29
@sandbergja sandbergja restored the i2069-iso639-3 branch April 4, 2023 14:40
@sandbergja sandbergja deleted the i2069-iso639-3 branch April 4, 2023 14:51
@sandbergja sandbergja restored the i2069-iso639-3 branch April 4, 2023 15:15
@sandbergja sandbergja deleted the i2069-iso639-3 branch April 4, 2023 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants