fix update_many with new columns #436
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes a bug where updating many records with new columns and ensuring those columns are created would raise a
sqlalchemy.exc.CompileError
exception as reported in #409the pull request includes two new unit-tests:
ensure
argument is set toFalse
in making these changes i did not consider the cases under point 2, i'm uncertain what the right behaviour should be under those circumstances
as stated by @4l1fe in #409 this solution may work on other methods
i wouldn't mind working on this if there is some indication the work will get merged
ping @pudo, @gka