Added function PNFuture.await() #338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
as a convenient function for those users that use coroutines. New module pubnub-kotlin-coroutines has been created.
marcin-cebo
requested review from
kleewho,
wkal-pubnub and
jguz-pubnub
as code owners
wkal-pubnub
approved these changes
Mar 6, 2025
| import kotlin.coroutines.resumeWithException | ||
|
|
||
| suspend fun <T> PNFuture<T>.await(): T { | ||
| val t = suspendCancellableCoroutine { cont -> |
There was a problem hiding this comment.
nit: t isn't needed, I'd just do suspend fun <T> PNFuture<T>.await(): T = suspendCancellableCoroutine { ...
There was a problem hiding this comment.
ok, I will change it.
|
|
||
| class UtilKtTest { | ||
| @Test | ||
| fun `await returns result on success`() = runBlocking { |
There was a problem hiding this comment.
use runTest from kotlinx-coroutines-test instead of runBlocking
| import org.junit.jupiter.api.Test | ||
| import kotlin.test.assertFailsWith | ||
|
|
||
| class FakePNFuture<T>(private val block: (Consumer<com.pubnub.api.v2.callbacks.Result<T>>) -> Unit) : PNFuture<T> { |
There was a problem hiding this comment.
you don't really need it, I think you should be able to just do :
Unit.asFuture().then { error("exception!") }
or
expected.asFuture()
settings.gradle.kts
Outdated
| @@ -29,3 +29,4 @@ include("examples:kotlin-app") | |||
| include("examples:java-app") | |||
| includeBuild("build-logic/ktlint-custom-rules") | |||
| includeBuild("migration_utils") | |||
| include("pubnub-kotlin-coroutines") | |||
There was a problem hiding this comment.
I would maybe put it in the pubnub-kotlin directory, but it's not critical, I think when you release it to maven the end result is the same
wkal-pubnub
approved these changes
Mar 7, 2025
|
@pubnub-release-bot release kotlin as v10.4.5 |
|
🚀 Release successfully completed 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: Internal fixes.