Fix some iOS KMP converters (#336)

* Some iOS converters were putting empty strings into objects instead of null * PubNub SDK v10.4.3 release. --------- Co-authored-by: PubNub Release Bot <[email protected]>
pubnub · Feb 28, 2025 · c30e2f0 · c30e2f0
1 parent f3ecdda
commit c30e2f0
Show file tree

Hide file tree

Showing 10 changed files with 42 additions and 28 deletions.
diff --git a/.pubnub.yml b/.pubnub.yml
@@ -1,9 +1,9 @@
 name: kotlin
-version: 10.4.2
+version: 10.4.3
 schema: 1
 scm: github.com/pubnub/kotlin
 files:
-  - build/libs/pubnub-kotlin-10.4.2-all.jar
+  - build/libs/pubnub-kotlin-10.4.3-all.jar
 sdks:
   - 
       type: library
@@ -23,8 +23,8 @@ sdks:
             -
               distribution-type: library
               distribution-repository: maven
-              package-name: pubnub-kotlin-10.4.2
-              location: https://repo.maven.apache.org/maven2/com/pubnub/pubnub-kotlin/10.4.2/pubnub-kotlin-10.4.2.jar
+              package-name: pubnub-kotlin-10.4.3
+              location: https://repo.maven.apache.org/maven2/com/pubnub/pubnub-kotlin/10.4.3/pubnub-kotlin-10.4.3.jar
               supported-platforms:
                 supported-operating-systems:
                   Android:
@@ -121,6 +121,11 @@ sdks:
                   license-url: https://www.apache.org/licenses/LICENSE-2.0.txt
                   is-required: Required
 changelog:
+  - date: 2025-02-28
+    version: v10.4.3
+    changes:
+      - type: bug
+        text: "Internal fixes."
   - date: 2025-02-25
     version: v10.4.2
     changes:

diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,3 +1,9 @@
+## v10.4.3
+February 28 2025
+
+#### Fixed
+- Internal fixes.
+
 ## v10.4.2
 February 25 2025
 

diff --git a/README.md b/README.md
@@ -20,7 +20,7 @@ You will need the publish and subscribe keys to authenticate your app. Get your
      <dependency>
         <groupId>com.pubnub</groupId>
         <artifactId>pubnub-kotlin</artifactId>
-        <version>10.4.2</version>
+        <version>10.4.3</version>
      </dependency>
      ```
 

diff --git a/gradle.properties b/gradle.properties
@@ -18,7 +18,7 @@ RELEASE_SIGNING_ENABLED=true
 SONATYPE_HOST=DEFAULT
 SONATYPE_AUTOMATIC_RELEASE=false
 GROUP=com.pubnub
-VERSION_NAME=10.4.2
+VERSION_NAME=10.4.3
 POM_PACKAGING=jar
 
 POM_NAME=PubNub SDK

diff --git a/...pubnub-kotlin-api/src/appleMain/kotlin/com/pubnub/api/endpoints/files/DownloadFile.ios.kt b/...pubnub-kotlin-api/src/appleMain/kotlin/com/pubnub/api/endpoints/files/DownloadFile.ios.kt
@@ -29,10 +29,11 @@ class DownloadFileImpl(
             channel = channel,
             fileName = fileName,
             fileId = fileId,
-            onSuccess = callback.onSuccessHandler {
+            onSuccess = callback.onSuccessHandler { file ->
+                requireNotNull(file)
                 PNDownloadFileResult(
-                    fileName = it?.name().orEmpty(),
-                    byteStream = it?.url()?.let { url -> DownloadableImpl(inputStream = NSInputStream(uRL = url)) }
+                    fileName = file.name(),
+                    byteStream = file.url()?.let { url -> DownloadableImpl(inputStream = NSInputStream(uRL = url)) }
                 )
             },
             onFailure = callback.onFailureHandler()

diff --git a/...n/pubnub-kotlin-api/src/appleMain/kotlin/com/pubnub/api/endpoints/files/GetFileUrl.ios.kt b/...n/pubnub-kotlin-api/src/appleMain/kotlin/com/pubnub/api/endpoints/files/GetFileUrl.ios.kt
@@ -27,7 +27,7 @@ class GetFileUrlImpl(
             channel = channel,
             fileName = fileName,
             fileId = fileId,
-            onSuccess = callback.onSuccessHandler { PNFileUrlResult(url = it.orEmpty()) },
+            onSuccess = callback.onSuccessHandler { PNFileUrlResult(url = requireNotNull(it)) },
             onFailure = callback.onFailureHandler()
         )
     }

diff --git a/...lin/pubnub-kotlin-api/src/appleMain/kotlin/com/pubnub/api/endpoints/files/SendFile.ios.kt b/...lin/pubnub-kotlin-api/src/appleMain/kotlin/com/pubnub/api/endpoints/files/SendFile.ios.kt
@@ -50,12 +50,13 @@ class SendFileImpl(
                 shouldStore = shouldStore?.let { NSNumber(it) },
                 customMessageType = customMessageType,
                 onSuccess = callback.onSuccessHandler2 { uploadedFile, timetoken ->
+                    requireNotNull(uploadedFile)
                     PNFileUploadResult(
                         status = 200,
                         timetoken = timetoken.toLong(),
                         file = PNBaseFile(
-                            id = uploadedFile?.id().orEmpty(),
-                            name = uploadedFile?.name().orEmpty()
+                            id = uploadedFile.id(),
+                            name = uploadedFile.name()
                         )
                     )
                 },

diff --git a/...api/src/appleMain/kotlin/com/pubnub/api/endpoints/message_actions/AddMessageAction.ios.kt b/...api/src/appleMain/kotlin/com/pubnub/api/endpoints/message_actions/AddMessageAction.ios.kt
@@ -31,14 +31,15 @@ class AddMessageActionImpl(
             actionValue = actionValue,
             messageTimetoken = messageTimetoken.toULong(),
             onSuccess = callback.onSuccessHandler { messageActionObjC ->
+                requireNotNull(messageActionObjC)
                 PNAddMessageActionResult(
                     action = PNMessageAction(
-                        type = messageActionObjC?.actionType().orEmpty(),
-                        value = messageActionObjC?.actionValue().orEmpty(),
-                        messageTimetoken = messageActionObjC?.messageTimetoken()?.toLong() ?: 0,
+                        type = messageActionObjC.actionType(),
+                        value = messageActionObjC.actionValue(),
+                        messageTimetoken = messageActionObjC.messageTimetoken().toLong(),
                     ).apply {
-                        uuid = messageActionObjC?.publisher()
-                        actionTimetoken = messageActionObjC?.actionTimetoken()?.toLong()
+                        uuid = messageActionObjC.publisher()
+                        actionTimetoken = messageActionObjC.actionTimetoken().toLong()
                     }
                 )
             },

diff --git a/pubnub-kotlin/pubnub-kotlin-api/src/appleMain/kotlin/com/pubnub/kmp/converters.kt b/pubnub-kotlin/pubnub-kotlin-api/src/appleMain/kotlin/com/pubnub/kmp/converters.kt
@@ -49,9 +49,9 @@ internal fun createPNUUIDMetadata(from: KMPUserMetadata?): PNUUIDMetadata {
         externalId = PatchValue.of(from.externalId()),
         profileUrl = PatchValue.of(from.profileUrl()),
         email = PatchValue.of(from.email()),
-        custom = PatchValue.of(from.custom()?.safeCast()),
-        updated = PatchValue.of(from.updated().orEmpty()),
-        eTag = PatchValue.of(from.eTag().orEmpty()),
+        custom = from.custom()?.safeCast<String, Any>()?.let { PatchValue.of(it) },
+        updated = from.updated()?.let { PatchValue.of(it) },
+        eTag = from.eTag()?.let { PatchValue.of(it) },
         type = PatchValue.of(from.type()),
         status = PatchValue.of(from.status())
     )
@@ -64,9 +64,9 @@ internal fun createPNChannelMetadata(from: KMPChannelMetadata?): PNChannelMetada
         id = from!!.id(),
         name = PatchValue.of(from.name()),
         description = PatchValue.of(from.descr()),
-        custom = PatchValue.of(from.custom()?.safeCast()),
-        updated = PatchValue.of(from.updated().orEmpty()),
-        eTag = PatchValue.of(from.eTag().orEmpty()),
+        custom = from.custom()?.safeCast<String, Any>()?.let { PatchValue.of(it) },
+        updated = from.updated()?.let { PatchValue.of(it) },
+        eTag = from.eTag()?.let { PatchValue.of(it) },
         type = PatchValue.of(from.type()),
         status = PatchValue.of(from.status())
     )
@@ -90,9 +90,9 @@ internal fun createPNChannelMembership(from: KMPMembershipMetadata): PNChannelMe
             id = from.channelMetadataId(),
             name = PatchValue.of(from.channel()?.name()),
             description = PatchValue.of(from.channel()?.descr()),
-            custom = PatchValue.of(from.channel()?.custom()?.safeCast()),
-            updated = PatchValue.of(from.channel()?.updated().orEmpty()),
-            eTag = PatchValue.of(from.channel()?.eTag().orEmpty()),
+            custom = from.channel()?.custom()?.safeCast<String, Any>()?.let { PatchValue.of(it) },
+            updated = from.channel()?.updated()?.let { PatchValue.of(it) },
+            eTag = from.channel()?.eTag()?.let { PatchValue.of(it) },
             type = PatchValue.of(from.channel()?.type()),
             status = PatchValue.of(from.channel()?.status())
         ),
@@ -109,7 +109,7 @@ internal fun createPNChannelMembership(from: KMPMembershipMetadata): PNChannelMe
 internal fun createPNMember(from: KMPMembershipMetadata?): PNMember {
     return PNMember(
         uuid = createPNUUIDMetadata(from = from!!.user()),
-        custom = PatchValue.of(from.custom()?.safeCast()),
+        custom = from.custom()?.safeCast<String, Any>()?.let { PatchValue.of(it) },
         updated = from.updated().orEmpty(),
         eTag = from.eTag().orEmpty(),
         status = PatchValue.of(from.status()),

diff --git a/pubnub-kotlin/pubnub-kotlin-impl/src/test/kotlin/com/pubnub/api/legacy/PubNubImplTest.kt b/pubnub-kotlin/pubnub-kotlin-impl/src/test/kotlin/com/pubnub/api/legacy/PubNubImplTest.kt
@@ -56,7 +56,7 @@ class PubNubImplTest : BaseTest() {
     fun getVersionAndTimeStamp() {
         val version = PubNubImpl.SDK_VERSION
         val timeStamp = PubNubImpl.timestamp()
-        assertEquals("10.4.2", version)
+        assertEquals("10.4.3", version)
         assertTrue(timeStamp > 0)
     }