Add Chat.destroy() method, TimerManager class #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wkal-pubnub
requested review from
marcin-cebo and
jguz-pubnub
as code owners
wkal-pubnub
force-pushed
the
wkal/shutdown
branch
from
6d5a2c2 to
9e5ba02
Compare
wkal-pubnub
force-pushed
the
wkal/shutdown
branch
from
69ecd9e to
1968f04
Compare
jguz-pubnub
reviewed
Sep 5, 2024
pubnub-chat-impl/src/iosMain/kotlin/com/pubnub/chat/internal/timer/PlatformTimer.ios.kt
Outdated
Show resolved
Hide resolved
jguz-pubnub
reviewed
Sep 5, 2024
pubnub-chat-impl/src/iosMain/kotlin/com/pubnub/chat/internal/timer/PlatformTimer.ios.kt
Outdated
Show resolved
Hide resolved
…imer/PlatformTimer.ios.kt Co-authored-by: jguz-pubnub <[email protected]>
…imer/PlatformTimer.ios.kt Co-authored-by: jguz-pubnub <[email protected]>
marcin-cebo
approved these changes
Sep 6, 2024
| } | ||
|
|
||
| // this should run 3 times | ||
| // let's also try to start it from a background thread to test if cancellation works in that case |
There was a problem hiding this comment.
How do you check if cancellation works?
There was a problem hiding this comment.
if it's not cancelled by timerManager.destroy() then counter2.value will be > 3
at the end of the test we check if it's exactly 3
There was a problem hiding this comment.
I was expecting cancellation be executed like this:
val runPeriodically1: PlatformTimer
withContext(Dispatchers.Default) {
runPeriodically1 = timerManager.runPeriodically(0.5.seconds) {
counter2.incrementAndGet()
}
}
runPeriodically1.cancel()
There was a problem hiding this comment.
I'll add one more test to check cancellation with cancel()
|
looks like test was flaky, merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TimerManager is used to group PlatformTimers and let us cancel them when destroying Chat.