Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add membership type field #426

Merged
merged 3 commits into from
Dec 17, 2024
Merged

Add membership type field #426

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
80a6be0
feat(app-context): add membership type field
parfeon Dec 17, 2024
d9136fd
fix(logger): for logger for Node.js
parfeon Dec 17, 2024
a993c24
PubNub SDK v8.4.0 release.
pubnub-release-bot Dec 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions dist/web/pubnub.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6224,9 +6224,7 @@
delete payload.data;
}
else if ('action' in payload && payload.action === 'interval') {
// @ts-expect-error This is `interval` object which should have `hereNowRefresh` field.
payload['hereNowRefresh'] = (_a = payload.here_now_refresh) !== null && _a !== void 0 ? _a : false;
// @ts-expect-error Keeping only human-readable keys.
payload.hereNowRefresh = (_a = payload.here_now_refresh) !== null && _a !== void 0 ? _a : false;
delete payload.here_now_refresh;
}
}
Expand Down
2 changes: 1 addition & 1 deletion lib/node/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ class PubNub extends pubnub_common_1.PubNubCore {
if (process.env.CRYPTO_MODULE !== 'disabled')
cryptography = new node_2.default();
// Setup transport provider.
const transport = new node_transport_1.NodeTransport(configuration.keepAlive, configuration.keepAliveSettings);
const transport = new node_transport_1.NodeTransport(configuration.keepAlive, configuration.keepAliveSettings, clientConfiguration.logVerbosity);
const transportMiddleware = new middleware_1.PubNubMiddleware({
clientConfiguration,
tokenManager,
Expand Down
2 changes: 1 addition & 1 deletion lib/types/index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5952,7 +5952,7 @@ declare namespace PubNub {
*/
status?: string;
/**
* Channel's membership type.
* Channel's member type.
*/
type?: string;
/**
Expand Down
6 changes: 5 additions & 1 deletion src/node/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,11 @@ class PubNub extends PubNubCore<string | ArrayBuffer | Buffer | Readable, PubNub
if (process.env.CRYPTO_MODULE !== 'disabled') cryptography = new NodeCryptography();

// Setup transport provider.
const transport = new NodeTransport(configuration.keepAlive, configuration.keepAliveSettings);
const transport = new NodeTransport(
configuration.keepAlive,
configuration.keepAliveSettings,
clientConfiguration.logVerbosity!,
mohitpubnub marked this conversation as resolved.
Show resolved Hide resolved
);
const transportMiddleware = new PubNubMiddleware({
clientConfiguration,
tokenManager,
Expand Down
3 changes: 1 addition & 2 deletions test/integration/endpoints/subscribe.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@ describe('subscribe endpoints', () => {
// @ts-expect-error Force override default value.
useRequestId: false,
autoNetworkDetection: false,
logVerbosity: true,
});
pubnubWithFiltering = new PubNub({
subscribeKey: 'mySubKey',
Expand Down Expand Up @@ -203,7 +202,7 @@ describe('subscribe endpoints', () => {
});
});

it('supports timetoken', (done) => {
it.only('supports timetoken', (done) => {
const scope0 = utils
.createNock()
.get('/v2/subscribe/mySubKey/c1/0')
Expand Down