Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add membership type field #426

Merged
merged 3 commits into from
Dec 17, 2024
Merged

Add membership type field #426

merged 3 commits into from
Dec 17, 2024

Conversation

parfeon
Copy link
Contributor

@parfeon parfeon commented Dec 17, 2024

feat(app-context): add membership type field

Add type field for members and membership objects and subscribe response.

fix(app-context): fix type which limited options setting membership

Fixed type which limited number of options which can be included into response / used in sorting for members / membership setting API.

fix(presence): fix missing presence event flag

Fix missing hereNowRefresh flag from the presence object received from subscribe.

fix(logger): for logger for Node.js

Fix issue because of which logVerbosity set to true still didn't print logs for Node.js.

refactor(logging): change format and add proper request body output.

Add `type` field for members and membership objects and subscribe response.

fix(app-context): fix type which limited options setting membership

Fixed type which limited number of options which can be included into response / used in sorting
for members / membership setting API.

fix(presence): fix missing presence event flag

Fix missing `hereNowRefresh` flag from the presence object received from subscribe.

refactor(logging): change format and add proper request body output
@parfeon parfeon added status: done This issue is considered resolved. priority: medium This PR should be reviewed after all high priority PRs. type: feature This PR contains new feature. labels Dec 17, 2024
@parfeon parfeon self-assigned this Dec 17, 2024
Fix issue because of which `logVerbosity` set to `true` still didn't print logs for Node.js.
src/node/index.ts Show resolved Hide resolved
@parfeon
Copy link
Contributor Author

parfeon commented Dec 17, 2024

@pubnub-release-bot release

@parfeon parfeon merged commit 6a9fa7d into master Dec 17, 2024
6 of 7 checks passed
@parfeon parfeon deleted the CLEN-2331 branch December 17, 2024 12:41
@pubnub-release-bot
Copy link
Contributor

🚀 Release successfully completed 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: medium This PR should be reviewed after all high priority PRs. status: done This issue is considered resolved. type: feature This PR contains new feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants