fix:signature mistmatch with encrypted data #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jguz-pubnub
reviewed
Jan 22, 2024
| @@ -55,3 +55,6 @@ ${'$body' == 'null' ? '' : '$body'}'''; | |||
| .replaceAll(RegExp(r'\/'), '_') | |||
| .replaceAll(RegExp(r'\=*$'), ''); | |||
| } | |||
|
|
|||
| String encodePathSegament(String pathSegment) => | |||
| Uri.encodeFull(pathSegment).replaceAll('/', '%2F').replaceAll('#', '%23'); | |||
There was a problem hiding this comment.
I'm just curious, why Uri.encodeFull method doesn't encode the whole path segment? Looks like you have to still replace / with %2F and # with %23
There was a problem hiding this comment.
encodeFull consider / as path segment separation character which is correct.
We may use encodecomponent but It encodes all special characters which doesn't fit our requirement for signature calculation and we may need to reverse by selecting like this:
Uri.encodeComponent(pathSegment).replaceAllMapped(
RegExp('%3D|%2B|%3A|%2A|%2C|%40|%24|%26|%28|%29'),
(match) => {
'%3D': '=',
'%2B': '+',
'%3A': ':',
'%2A': '*',
'%2C': ',',
'%40': '@',
'%24': '\$',
'%26': '&',
'%28': '(',
'%29': ')',
}[match.group(0)]!);
jguz-pubnub
approved these changes
Jan 22, 2024
|
@pubnub-release-bot release dart as v4.3.2 |
techwritermat
approved these changes
Jan 22, 2024
|
🚀 Release successfully completed 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: signature mismatch due to encoding difference
Fixes issue of getting signature mismatch exception while publishing encrypted data.