Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove inline styles assigned in ERB templates #128

Merged
merged 8 commits into from
Nov 12, 2023
Merged

Remove inline styles assigned in ERB templates #128

merged 8 commits into from
Nov 12, 2023

Commits on Nov 12, 2023

  1. Hide spinner initially with a class

    @mvz
    mvz committed Nov 12, 2023
    Configuration menu
    Copy the full SHA
    a026ae5 View commit details
    Browse the repository at this point in the history

  2. Remove superfluous break

    @mvz
    mvz committed Nov 12, 2023
    Configuration menu
    Copy the full SHA
    9d0b8c3 View commit details
    Browse the repository at this point in the history

  3. Hide optional comment form fields with JavaScript 

    This changes removes inline styles, and makes the comment form show the
optional fields when JavaScript is disabled. This is a good thing since
otherwise these fields could never be filled in that case.
    @mvz
    mvz committed Nov 12, 2023
    Configuration menu
    Copy the full SHA
    68cf5e4 View commit details
    Browse the repository at this point in the history

  4. Apply tag cloud styling using a class

    @mvz
    mvz committed Nov 12, 2023
    Configuration menu
    Copy the full SHA
    98ce17b View commit details
    Browse the repository at this point in the history

  5. Ensure panel heading height using a class 

    The original break was present to ensure the heading was high enough to
contain the floating search form. Using the clearfix class achieves the
same effect.
    @mvz
    mvz committed Nov 12, 2023
    Configuration menu
    Copy the full SHA
    bff75ef View commit details
    Browse the repository at this point in the history

  6. Fix admin flash position without inline styling

    @mvz
    mvz committed Nov 12, 2023
    Configuration menu
    Copy the full SHA
    e92f16a View commit details
    Browse the repository at this point in the history

  7. Initially hide comment feedback elements using a class

    @mvz
    mvz committed Nov 12, 2023
    Configuration menu
    Copy the full SHA
    e9a4596 View commit details
    Browse the repository at this point in the history

  8. Group tags into buckets with statically assigned sizes

    @mvz
    mvz committed Nov 12, 2023
    Configuration menu
    Copy the full SHA
    e5382f7 View commit details
    Browse the repository at this point in the history