Skip to content

Conversation

@bihechen
Copy link

@bihechen bihechen commented Mar 6, 2019

fix ipad authoration problem

@ebarry
Copy link
Member

ebarry commented Mar 6, 2019

Hi! are you seeking reviewers or are you ready for this to be merged?

@shapironick
Copy link
Collaborator

Seeking reviewers! is there a "needs review" label? I think we have that over in EDGI but might be wrong.

@ebarry
Copy link
Member

ebarry commented Mar 6, 2019

Hi @publiclab/reviewers , can you take a look at this contribution? Thanks!

@ebarry
Copy link
Member

ebarry commented Mar 6, 2019

This PR addresses part of #18, specifically feedback from a beta tester using an Ipad: "I get the "align triangle" screen but it doesn't appear that the camera is turned on. I'm attaching a screen shot of that, too. If I push the button to take a picture, it takes a "photo" that is all black."

47922497-9d8fc480-de8d-11e8-8cf5-e21d94ea8be1

@ebarry
Copy link
Member

ebarry commented Mar 6, 2019

@bihechen thank you so much for your contribution! I also read in #18 that you had said "Our original version runs well on iPhone but lack the process to check and apply rights from user, which lead to that problem [of the camera not being accessible]"

Can you confirm that this is specifically what your PR is fixing? Or clarify? Thanks!

@shapironick
Copy link
Collaborator

Maybe @ShaneYY or @rongjun-qin-321 could review this suggested update?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants