-
Notifications
You must be signed in to change notification settings - Fork 4
iOS change #19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
iOS change #19
Conversation
|
Hi! are you seeking reviewers or are you ready for this to be merged? |
|
Seeking reviewers! is there a "needs review" label? I think we have that over in EDGI but might be wrong. |
|
Hi @publiclab/reviewers , can you take a look at this contribution? Thanks! |
|
This PR addresses part of #18, specifically feedback from a beta tester using an Ipad: "I get the "align triangle" screen but it doesn't appear that the camera is turned on. I'm attaching a screen shot of that, too. If I push the button to take a picture, it takes a "photo" that is all black." |
|
@bihechen thank you so much for your contribution! I also read in #18 that you had said "Our original version runs well on iPhone but lack the process to check and apply rights from user, which lead to that problem [of the camera not being accessible]" Can you confirm that this is specifically what your PR is fixing? Or clarify? Thanks! |
|
Maybe @ShaneYY or @rongjun-qin-321 could review this suggested update? |

fix ipad authoration problem