Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove @public-ui/themes and @public-ui/designer packages #7249

Merged
merged 11 commits into from
Feb 5, 2025
Merged

Remove @public-ui/themes and @public-ui/designer packages #7249

merged 11 commits into from
Feb 5, 2025

Conversation

sdvg
Copy link
Member

@sdvg sdvg commented Jan 20, 2025 •
edited
Loading

Refs: #7155

The A11y and PO reviews will only take place after all other DoD steps have been completed by the Developer:

  • Meaningful pull request title for the release notes
  • Pull request is linked to an issue and all changes relate to the issue
  • Tests to protect this code implemented (if applicable)
  • Manual test performed successfully (if applicable)
  • Documentation or migration has been updated (if applicable)

@sdvg sdvg linked an issue Jan 20, 2025 that may be closed by this pull request
Deprecate @public-ui/themes #7155
Closed
@sdvg sdvg linked an issue Jan 20, 2025 that may be closed by this pull request
Designer-Paket aus develop Branch entfernen #7250
Closed
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 20, 2025 •
edited
Loading

Netlify Draft Deployment
URL: https://67a1f0e751f81f41316383e7--kolibri-public-ui.netlify.app
Logs: https://app.netlify.com/sites/kolibri-public-ui/deploys/67a1f0e751f81f41316383e7

@sdvg sdvg changed the title Remove @public-ui/themes package build Remove @public-ui/themes and @public-ui/designer packages Jan 20, 2025
sdvg and others added 3 commits January 20, 2025 17:30
@sdvg
Merge branch 'develop' into 7155-deprecate-themes-v3
39d1682
@sdvg
Add knip exceptions
5280a19 
Refs: #7155
@sdvg
Merge remote-tracking branch 'origin/7155-deprecate-themes-v3' into 7…
115f58b 
…155-deprecate-themes-v3

* origin/7155-deprecate-themes-v3:
  Update all snapshots$ $ Refs: #6899
  delete modal from controlled.tsx
  delete modal in the sample
  remove _modal
  Fix test
  Remove modal property in Drawer
@sdvg sdvg marked this pull request as ready for review January 22, 2025 09:03
@deleonio
Copy link
Contributor

@sdvg: Kannst du bitte mal nach der DoD schauen. Ist da noch was offen?

deleonio and others added 2 commits January 29, 2025 05:54
@deleonio
Merge branch 'develop' of https://github.com/public-ui/kolibri into 7…
3bae09a 
…155-deprecate-themes-v3
@sdvg
Merge branch 'develop' of github.com:public-ui/kolibri into 7155-depr…
af9dddd 
…ecate-themes-v3

* 'develop' of github.com:public-ui/kolibri:
  Update all snapshots$ $ Refs: #5844
  chore: release 3.0.0-rc.3
  Fix concurrency group syntax in dod-checker workflow
  Remove auto file generator workflow
  remove some prepack scripts
  Update all snapshots$ $ Refs: #7310
  Fix duplicate import of 'h' in shadow.tsx component
  Fix formRef initialization to handle null value in FormErrorList component
  Enhance error list functionality: improve scrolling and focus behavior for error links
  Enhance error list rendering: add smooth scroll and focus behavior for alert component
  Fix test
  Update all snapshots$ $ Refs: #5844
  set initial focus to slot area
  Refactor modal and add snapshots tests
  Update all snapshots$ $ Refs: #5844
  Fix lint error
  Fix imports
  Add styles, e2e tests and update sample app
  Add close button for modal
@deleonio deleonio merged commit 674006c into develop Feb 5, 2025
9 of 10 checks passed
@deleonio deleonio deleted the 7155-deprecate-themes-v3 branch February 5, 2025 07:01
@github-actions github-actions bot locked and limited conversation to collaborators Feb 5, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@deleonio deleonio deleonio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Designer-Paket aus develop Branch entfernen Deprecate @public-ui/themes
2 participants
@sdvg @deleonio