Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: update input components css to use bem styles and mixins #7180

Merged
merged 45 commits into from
Jan 24, 2025
Merged

refactor: update input components css to use bem styles and mixins #7180

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
45 commits
Select commit Hold shift + click to select a range
700397a
refactor: update input components css to use bem styles and mixins
Makko74 Dec 10, 2024
e2e3b9c
feat: add FieldControl and FieldControlStateWrapper components and be…
Makko74 Dec 12, 2024
f9b9cc0
feat: reactoring and update sccs in input components to use bem styles
Makko74 Dec 16, 2024
461ada2
Merge branch 'refactoring/7032-field-input-components' into refactori…
Makko74 Dec 16, 2024
9ba7f9b
Merge branch 'develop' of github.com:public-ui/kolibri into refactori…
sdvg Jan 14, 2025
52e3d94
Fix typo
sdvg Jan 14, 2025
39d0be0
Fix minor styling issues
sdvg Jan 14, 2025
1b4a1c0
Fix select styles
sdvg Jan 14, 2025
fbe86fb
Fix missing accessKey
sdvg Jan 15, 2025
0ccf4ef
Fix typo
sdvg Jan 15, 2025
380325f
Hide badges from radio options
sdvg Jan 15, 2025
cf6b938
Merge branch 'develop' of github.com:public-ui/kolibri into refactori…
sdvg Jan 15, 2025
4252b70
Fix missing shortKey badge
sdvg Jan 16, 2025
c3c67e0
Remove opacity for messages on disabled fields
sdvg Jan 16, 2025
0327155
Update all snapshots$
sdvg Jan 16, 2025
50088ea
Update Jest snapshot
sdvg Jan 16, 2025
21f3228
Rename style to global
sdvg Jan 16, 2025
fc14b7d
Unify mixin style
sdvg Jan 16, 2025
1c53547
Refactor color
sdvg Jan 16, 2025
c6b438f
Refactor scss
sdvg Jan 16, 2025
597451a
Update components
sdvg Jan 17, 2025
21242bc
Merge branch 'develop' of github.com:public-ui/kolibri into refactori…
sdvg Jan 17, 2025
908b75c
Update all snapshots$
sdvg Jan 17, 2025
78d932c
Update Jest snapshots
sdvg Jan 17, 2025
abffafc
Merge remote-tracking branch 'origin/refactoring/7178-convert-input-s…
sdvg Jan 17, 2025
ffd8b65
Fix focus styles
sdvg Jan 17, 2025
e76198c
Update all snapshots$
sdvg Jan 17, 2025
18d215c
Fix e2e
sdvg Jan 17, 2025
d7a78fe
Refactor radio and checkbox
sdvg Jan 17, 2025
e9eb017
Refactor theme checkbox
sdvg Jan 17, 2025
529a1b9
Refactor base styles
sdvg Jan 17, 2025
9bb09a6
Refactor base styles
sdvg Jan 17, 2025
b24574c
Merge branch 'develop' of github.com:public-ui/kolibri into refactori…
sdvg Jan 17, 2025
007602e
Add missing tooltip styles
sdvg Jan 17, 2025
eb4a2b7
Fix combobox and single-select focus styles
sdvg Jan 17, 2025
c0b3a76
Refactor
sdvg Jan 17, 2025
31b5a58
Update all snapshots$
sdvg Jan 17, 2025
20ee66e
Refactor default theme styles
sdvg Jan 18, 2025
222376f
Merge remote-tracking branch 'origin/refactoring/7178-convert-input-s…
sdvg Jan 18, 2025
53f9a25
Fix error messages
sdvg Jan 18, 2025
1897d0f
Cleanup EU themes
sdvg Jan 18, 2025
a682975
KolInputRange: Fix width calculation for number input
sdvg Jan 22, 2025
62fe56e
Update all snapshots$
sdvg Jan 22, 2025
5f1df38
Merge branch 'develop' of github.com:public-ui/kolibri into refactori…
sdvg Jan 22, 2025
5cfb819
Update all snapshots$
laske185 Jan 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
5 changes: 3 additions & 2 deletions packages/components/src/components/a11y.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
@import '@shared/mixins';

/*
* This file contains all rules for accessibility.
*/
Expand Down Expand Up @@ -47,8 +49,7 @@
/* select, */
/* textarea, */
[role='button'],
button:not([role='link']),
.kol-input .input {
button:not([role='link']) {
min-height: var(--a11y-min-size);
min-width: var(--a11y-min-size);
}
Expand Down
2 changes: 1 addition & 1 deletion packages/components/src/components/abbr/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
@import '../@shared/mixins';
@import '../style';
@import '../../styles/global';
@import '../tooltip/style.scss';

@layer kol-component {
Expand Down
2 changes: 1 addition & 1 deletion packages/components/src/components/accordion/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
@import '../@shared/mixins';
@import '../style';
@import '../../styles/global';
@import '../host-display-block';
@import '../../functional-components/Collapsible/collapsible';

Expand Down
8 changes: 4 additions & 4 deletions packages/components/src/components/alert/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
@import '../../styles/global';
@import '../../styles/kol-alert-mixin';
@import '../@shared/mixins';
@import '../style';
@import '../@shared/kol-alert-mixin';

@include kol-alert;

@layer kol-component {
.kol-alert {
font-size: rem(16);
}
}

@include kol-alert-styles;
2 changes: 1 addition & 1 deletion packages/components/src/components/avatar/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
@import '../@shared/mixins';
@import '../style';
@import '../../styles/global';
@import '../host-display-block';

@layer kol-component {
Expand Down
2 changes: 1 addition & 1 deletion packages/components/src/components/badge/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
@import '../@shared/mixins';
@import '../style';
@import '../../styles/global';
@import '../tooltip/style.scss';

@layer kol-component {
Expand Down
2 changes: 1 addition & 1 deletion packages/components/src/components/breadcrumb/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
@import '../@shared/mixins';
@import '../style';
@import '../../styles/global';

@layer kol-component {
.kol-breadcrumb {
Expand Down
2 changes: 1 addition & 1 deletion packages/components/src/components/button-link/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
@import '../@shared/mixins';
@import '../style';
@import '../../styles/global';
@import '../@shared/kol-link-mixin';

@include kol-link-styles('kol-button');
2 changes: 1 addition & 1 deletion packages/components/src/components/button/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
@import '../@shared/mixins';
@import '../style';
@import '../../styles/global';
@import '../@shared/kol-button-mixin';

@include kol-button-styles('kol-button');
2 changes: 1 addition & 1 deletion packages/components/src/components/card/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
@import '../@shared/mixins';
@import '../style';
@import '../../styles/global';
@import '../tooltip/style.scss';

@layer kol-component {
Expand Down
13 changes: 11 additions & 2 deletions packages/components/src/components/combobox/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
@import '../../styles/global';
@import '../@shared/mixins';
@import '../style';
@import '../input-line';
@import '../host-display-block';
@import '../tooltip/style';

@layer kol-component {
:host {
Expand Down Expand Up @@ -28,6 +29,10 @@

&__input {
flex-grow: 1;

&:focus {
outline: none;
}
}

&__icon {
Expand Down Expand Up @@ -59,4 +64,8 @@
}
}
}

.kol-input {
display: grid;
}
}
2 changes: 1 addition & 1 deletion packages/components/src/components/details/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
@import '../@shared/mixins';
@import '../style';
@import '../../styles/global';
@import '../host-display-block';
@import '../../functional-components/Collapsible/collapsible';

Expand Down
2 changes: 1 addition & 1 deletion packages/components/src/components/drawer/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
@import '../@shared/mixins';
@import '../style';
@import '../../styles/global';

@layer kol-component {
.kol-drawer {
Expand Down
8 changes: 5 additions & 3 deletions packages/components/src/components/form/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,13 @@
@import '../@shared/mixins';
@import '../style';
@import '../input-line';
@import '../../styles/global';
@import '../host-display-block';
@import '../@shared/kol-link-mixin';
@import '../../styles/kol-alert-mixin';

@layer kol-component {
@include kol-link-styles('kol-link');
@include kol-alert-styles;
@include kol-alert;

.kol-form {
font-size: rem(16);
}
Expand Down
2 changes: 1 addition & 1 deletion packages/components/src/components/heading/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
@import '../@shared/mixins';
@import '../style';
@import '../../styles/global';

@layer kol-component {
.kol-headline {
Expand Down
2 changes: 1 addition & 1 deletion packages/components/src/components/image/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
@import '../@shared/mixins';
@import '../style';
@import '../../styles/global';

@layer kol-component {
.kol-image {
Expand Down
43 changes: 0 additions & 43 deletions packages/components/src/components/input-checkbox/button.scss
View file
Open in desktop

This file was deleted.

29 changes: 0 additions & 29 deletions packages/components/src/components/input-checkbox/checkbox.scss
View file
Open in desktop

This file was deleted.

86 changes: 0 additions & 86 deletions packages/components/src/components/input-checkbox/common.scss
View file
Open in desktop

This file was deleted.

Loading
Loading