Skip to content

Commit

Permalink
Merge remote-tracking branch 'origin/7118-table-remove-as-td' into 71…
Browse files Browse the repository at this point in the history
…18-table-remove-as-td

* origin/7118-table-remove-as-td:
  Enable input color e2e test after upstream bug has been fixed
  • Loading branch information
sdvg committed Feb 6, 2025
2 parents f5fff84 + 54cfd78 commit 05b857a
Showing 1 changed file with 1 addition and 7 deletions.
8 changes: 1 addition & 7 deletions packages/components/src/e2e/input-callbacks-and-events.ts
Original file line number Diff line number Diff line change
Expand Up @@ -26,13 +26,7 @@ const testInputCallbacksAndEvents = <ElementType extends { _on?: InputTypeOnDefa
];

EVENTS.filter(([eventName]) => !omittedEvents.includes(eventName)).forEach(([nativeEventName, callbackName, kolEventName, testValue]) => {
test(`should call ${callbackName} callback when internal input emits ${nativeEventName}`, async ({ page, browserName }) => {
/* See https://github.com/microsoft/playwright/issues/33864 */
test.skip(
componentName === 'kol-input-color' && nativeEventName === 'click' && browserName === 'firefox',
'Clicking on an input[type=color] in Firefox currently makes the page close itself.',
);

test(`should call ${callbackName} callback when internal input emits ${nativeEventName}`, async ({ page }) => {
await page.setContent(`<${componentName} _label="Input" ${additionalProperties}></${componentName}>`);
const component = page.locator(componentName);
const input = selectInput ? selectInput(page) : page.locator(INPUTS_SELECTOR);
Expand Down

0 comments on commit 05b857a

Please sign in to comment.