Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable copr builds and add packit config #10

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

dhodovsk
Copy link

@dhodovsk dhodovsk commented Dec 3, 2019

Let us introduce packit service to you - the automation to integrate upstream open source projects into Fedora operating system.

After merging this PR, you are just a few steps away from RPM builds being automatically triggered on your PR's.
It means, that you'll be able to try and play with your change, packaged as an RPM.

But there is more. By using packit, you can for example enable adding new releases into Fedora Rawhide.

What are the next steps?

For more info, please:

@psss
Copy link
Owner

psss commented Dec 3, 2019

/packit copr-build

@packit-as-a-service
Copy link

There was an error while running a copr build:

Request is not in JSON format, there is probably a bug in the API code.

You can re-trigger copr build by adding a comment (/packit copr-build) into this pull request.

@TomasTomecek
Copy link

TomasTomecek commented Dec 12, 2019

^ that error is actually coming from kubernetes and the original cause is something like gateway error, whatever that means -_-

@TomasTomecek
Copy link

/packit build

@packit-as-a-service
Copy link

Congratulations! The build has finished successfully. 🍾

You can install the built RPMs by following these steps:

  • sudo yum install -y dnf-plugins-core on RHEL 8
  • sudo dnf install -y dnf-plugins-core on Fedora
  • dnf copr enable packit/psss-edd-10
  • And now you can install the packages.

Please note that the RPMs should be used only in a testing environment.

Copy link

@TomasTomecek TomasTomecek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

\o/

@packit-as-a-service
Copy link

There was an error while running a copr build:

The create-archive action did not output a path to the generated archive. Please make sure that an absolute path to the archive is printed.

You can re-trigger copr build by adding a comment (/packit copr-build) into this pull request.

@packit-as-a-service
Copy link

There was an error while running a copr build:

The create-archive action did not output a path to the generated archive. Please make sure that an absolute path to the archive is printed.

You can re-trigger copr build by adding a comment (/packit copr-build) into this pull request.

@psss
Copy link
Owner

psss commented Jan 7, 2020

Pushed further simplification which we've agreed on today's meeting. @lachmanfrantisek, please review if everything's as expected and let me know when the updated code is in production. Thanks.

@packit-as-a-service
Copy link

There was an error while creating a SRPM. You can re-trigger copr build by adding a comment (/packit copr-build) into this pull request.

Output:

make: *** No rule to make target 'packit-tarball'.  Stop.

Return code: 2

@packit-as-a-service
Copy link

There was an error while running a copr build:

The create-archive action did not output a path to the generated archive. Please make sure that an absolute path to the archive is printed.

You can re-trigger copr build by adding a comment (/packit copr-build) into this pull request.


actions:
create-archive:
- make tarball

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me locally on the packit master. Let's wait for the redeploy.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Looking forward :)

@lachmanfrantisek
Copy link

/packit build

@TomasTomecek
Copy link

:/

@lachmanfrantisek
Copy link

:/

I'll take a look on the paths for sandcastle (our sandboxing system) -- it's probably different than the local build.

@lachmanfrantisek
Copy link

lachmanfrantisek commented Jan 9, 2020

A little out-of-the topic info:

  • Dominika is working on removing unnecessary packit/rpm-build failed status:

Screenshot from 2020-01-09 09-46-48

Screenshot from 2020-01-09 09-47-49

@psss
Copy link
Owner

psss commented Jul 24, 2020

/packit build

@@ -28,6 +28,7 @@ build:

tarball: build
cd $(TMP) && tar cfj SOURCES/$(PACKAGE).tar.bz2 $(PACKAGE)
@printf "$(shell realpath $(TMP)/SOURCES/$(PACKAGE).tar.bz2)\n"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the problem here is that the path is absolute - it should ideally be relative within the project

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this the same issue as teemtee/tmt/pull/249. I've tried relative path there as well but it did not help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants