Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix github commented filter and wrong until #363

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Fix github commented filter and wrong until #363

wants to merge 6 commits into from

Commits on Oct 10, 2024

  1. Fix issue with wrong until in GitHub search

    @Felixoid
    Felixoid committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    010a0c5 View commit details
    Browse the repository at this point in the history

  2. Use $did as did --config in tests

    @Felixoid
    Felixoid committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    145861e View commit details
    Browse the repository at this point in the history

  3. Add tests that break in master with wrong --until

    @Felixoid
    Felixoid committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    6a1a32f View commit details
    Browse the repository at this point in the history

Commits on Oct 18, 2024

  1. Additional filter for commented issues and PRs 

    GH search API unable to identify if the issues and PRs were updated by
the user's comment. To make it reliable, one needs to search the
comments for the entity after the `since` date, sort them by created_at
field, and check if the comments in the given interval are created by
the user.
    @Felixoid
    Felixoid committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    36924b6 View commit details
    Browse the repository at this point in the history

  2. Rename add_option to add_group and add_groups 

    The name of the method in different classes was the same, although each
one did another thing. Renamed some of them to reflect the actual task.
    @Felixoid
    Felixoid committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    3c3cea4 View commit details
    Browse the repository at this point in the history

  3. Add --github-approximate-commented argument

    @Felixoid
    Felixoid committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    b0d0bf7 View commit details
    Browse the repository at this point in the history