Prevent duplicates in github issue stats #347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psss
approved these changes
Jan 2, 2024
There was a problem hiding this comment.
Thanks for the fix! Looks good. I'm only thinking: Shouldn't project id and issues id be sufficient to get a unique value? The owner should not affect anything. Proposing to simplify the comparison in 7a6fc8c. @maxandersen, could you please have a look if it's ok?
psss
changed the title
|
Project is not unique on GitHub. Need Owner to be part of name. |
|
Ah, I see, I thought it's the issue owner not the project owner. Now it makes sense. Sorry for the noise. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #346 by adding equals method to Issue class that uses org/repo/id as key