use urllib.parse() in sqlalchemy engine creation. Fixes #13

psrc · May 9, 2024 · ada51a6 · ada51a6
1 parent 2b79331
commit ada51a6
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 2 deletions.
diff --git a/psrcelmerpy/conn/connection.py b/psrcelmerpy/conn/connection.py
@@ -1,6 +1,7 @@
 from . import auth
 import sqlalchemy
 import pandas as pd
+import urllib
 
 class Connection:
 
@@ -42,7 +43,8 @@ def _create_engine(self):
                 self.server_name,
                 self.database_name
                 )
-            self.engine = sqlalchemy.create_engine("mssql+pyodbc:///?odbc_connect=%s" % conn_string)
+            params = urllib.parse.quote_plus(conn_string)
+            self.engine = sqlalchemy.create_engine("mssql+pyodbc:///?odbc_connect=%s" % params)
 
         except Exception as e:
             print(e.args[0])

diff --git a/psrcelmerpy/conn/elmer_conn.py b/psrcelmerpy/conn/elmer_conn.py
@@ -67,7 +67,6 @@ def stage_table(self, df, table_name):
             The data frame to write to the database
         table_name : str
             The name that the new staging table is to have.
-        
         """
         try:
             engine = self.engine

diff --git a/setup.py b/setup.py
@@ -11,6 +11,7 @@
     install_requires=['pandas',
                       #'scipy==1.10.1',
                       'pyodbc',
+                      'urllib',
                       'sqlalchemy',
                       'geopandas',
                       'shapely']