-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port usbhostfs_pc to libusb-1.0 #16
base: master
Are you sure you want to change the base?
Conversation
I've replaced the libusb-0.1 Windows files with the libusb-1.0 ones now (I chose the mingw 64 bit ones). It should be buildable with cygwin now, but I wasn't really able to test that yet. |
I did test trying to build it on msys2, but it wasn't working because the compiler couldn't find The command I used to build is |
I've converted this to a draft right now. This should be rebased on master after #20 is merged and extended a little bit to make sure the Windows version still works. The way of installing the driver is different with this version, so I'll need to describe that too. |
So far I really haven't been able to get this to work on Windows and I have no idea how to fix that. It just keeps disconnecting. So for now this will not be merged and I'll get back to this at a later time. |
Hi @sharkwouter is this still pending? :) |
Hey @wally4000, the problem with this one is that it works really well on Linux, but I have never managed to get this to work on Windows regardless of which driver I use. I do not know how to fix that. The code compiles and it seems to connect, but input is not accepted. It's a bit of a shame, this is generally a good improvement, but we need Windows support to work. |
Hello @sharkwouter I want to fork your branch and try to continue it, are you still working on this? |
@diamant3 go for it. I've not worked on this for a while, since I don't know how to get it working on Windows. On Linux it works completely fine. |
got it, thankss! |
At the moment usbhostfs_pc uses libusb-0.1, which is not really being shipped by many distributions anymore. There is libusb-compat, which does work, but it is preferable to not rely on legacy stuff in general. This addresses #15.
Some notes about this pull request:
Since I'm trying to earn a t-shirt as well, could a
hacktoberfest-accepted
label be attached to this PR if it's not seen as spam? Thanks! See hacktoberfest.com for more details on that.