Security refinements applied #207
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File: SettingsPage.php Ignored issues are at line numbers 608 and 665 Resons: explained with corresposing lines.
File: aad-sso-wordpress.php Igonred issues are at line nos. 628 through 631 Reason: var_export function returns mized output.
File: view/settings.php Issue: unescaped wp_nonce_url function.
Contributor
|
@psignoret this looks like a really welcome improvement. Pretty straightforward. Nice work @emfluenceindia :-) |
Author
|
Thank you very much for your nice words :) Glad to contribute!
…---------------------------------------------------------------------------
Regards,
Subrata Sarkar
Emfluence
+12025069125, +12025563514
Alternate email: [email protected]
*** Save tree! Save nature!! Save our Planet!!!
________________________________
From: Brad Kovach <[email protected]>
Sent: Monday, October 22, 2018 10:04:08 PM
To: psignoret/aad-sso-wordpress
Cc: Subrata Sarkar; Mention
Subject: Re: [psignoret/aad-sso-wordpress] Security refinements applied (#207)
@psignoret<https://github.com/psignoret> this looks like a really welcome improvement. Pretty straightforward. Nice work @emfluenceindia<https://github.com/emfluenceindia> :-)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#207 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AKj0pofWogGqZJWvqCwHrpb0aENkdJJtks5unfOAgaJpZM4Xze7f>.
|
Contributor
|
FWIW, these will escape raw HTML, so instead of a formatted code tag, you will see verbatim |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I have applied some security refinements based on PHPCS report using WordPress-Extra standards.
It would be nice if you please review them.
Thank you!